11-21-2022, 02:53 PM
(11-20-2022, 01:07 PM)Seeky Wrote: You can get weird bugs by manually disabling interrupts if a context switch happens after your mfmsr and before your mtmsr, and the msr is changed on another thread. OSLoadContext has special code to prevent this issue in OSDisableInterrupts (moves pc back to the start of the function if it was interrupted before the mtmsr), so really you should always call the actual function for this
Also, do you actually need interrupts disabled here?
Dolphin would sometimes crash. Maybe it's just an issue on my machine, but i included it just in case.