Nice work! I'm amazed at how good you are at ASM. I finished the ports, btw.
I went ahead and bolded your name for Code creator.
It's a nice touch I like to add to my own code threads. Feel free to move all the code credits before the gigantic wall of source (I do it sometimes if the source is very long lol).
For any branch instructions that are..
blt
ble
bgt
bge
You might want to get into the habit of using a logical comparison beforehand instead of signed (use cmplwi/cmplw instead of cmpwi/cmpw). It's not needed in this particular code, but you may run into an instance where the game treats the values logically, so if you are working with those values as signed, it could cause some issues.
The only time you wouldn't need logical comparisons for those branches if you know that negative values could be possible.
Also... you can see I edited the parts of the compiled code for PAL, J, and K for the analog stick byte load.
Those addresses are..
pal 80350583
ntsc-j 8034FF03
ntsc-k 8033E583
This would be a perfect time for you to learn Macros and set the source to compile the different analog byte locations depending on which region is designated for the compiler. - http://mkwii.com/showthread.php?tid=1083
Once again, great work!!!!
I went ahead and bolded your name for Code creator.
It's a nice touch I like to add to my own code threads. Feel free to move all the code credits before the gigantic wall of source (I do it sometimes if the source is very long lol).For any branch instructions that are..
blt
ble
bgt
bge
You might want to get into the habit of using a logical comparison beforehand instead of signed (use cmplwi/cmplw instead of cmpwi/cmpw). It's not needed in this particular code, but you may run into an instance where the game treats the values logically, so if you are working with those values as signed, it could cause some issues.
The only time you wouldn't need logical comparisons for those branches if you know that negative values could be possible.
Also... you can see I edited the parts of the compiled code for PAL, J, and K for the analog stick byte load.
Those addresses are..
pal 80350583
ntsc-j 8034FF03
ntsc-k 8033E583
This would be a perfect time for you to learn Macros and set the source to compile the different analog byte locations depending on which region is designated for the compiler. - http://mkwii.com/showthread.php?tid=1083
Once again, great work!!!!